Place IRAM and FLASH data in separate segments#1829
Merged
Conversation
… section conflicts Thanks to esp8266/Arduino#5116 Commonly occurs when attempting to inline header methods, generally more of a problem with GCC 4.8.
Contributor
|
Did you test this change? |
Contributor
Author
|
Yes, been running on real hardware without issue. Also benefits IRAM/flash usage as linker can discard unused bits. (Note my initial PR failed because I pulled out the original commit for this, which I'd subsequently updated.) |
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Oct 20, 2019
slaff
pushed a commit
that referenced
this pull request
Oct 21, 2019
* Fix section conflict for flash strings (see #1829) * Add optional `len` parameter to Flashstring::isEqual(const char*) * esp-open-lwip fussy about include paths and conflicts with definitions in SDK, so #undef them first to be sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves section conflict issues when attempting to inline header methods, generally more of a problem with GCC 4.8.
Thanks to esp8266/Arduino#5116