input/keyboard: Use hash for ID of KeymapFile
#1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes excessive keymap events with `virtual-keyboard-unstable-v1` clients like fcitx5. This depends on `sha2`. Adding a new dependency for this is annoying, but this is a fairly widely used crate. `blake3` could also work but is less widely used. Perhaps a dependency couple be avoided if `SipHasher` is good enough, but as I understand it's not really meant to guarantee an absence of collisions (but may be good enough in practice here?). I expect computing a hash won't impact performance much, compared to clients having to process excessive `keymap` events
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
- Coverage 19.17% 16.51% -2.67%
==========================================
Files 175 175
Lines 28562 26968 -1594
==========================================
- Hits 5478 4454 -1024
+ Misses 23084 22514 -570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes excessive keymap events with
virtual-keyboard-unstable-v1clients like fcitx5.This depends on
sha2. Adding a new dependency for this is annoying, but this is a fairly widely used crate.blake3could also work but is less widely used. Perhaps a dependency couple be avoided ifSipHasheris good enough, but as I understand it's not really meant to guarantee an absence of collisions (but may be good enough in practice here?).I expect computing a hash won't impact performance much, compared to clients having to process excessive
keymapevents