gles: Don't call GenTextures before make_current()
#1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unwrap_or_else()` call here in `import_shm_buffer()` has a call to `self.gl.GenTextures()`, but `self.egl.make_current()` was only being called in the next block. It appears this was the cause of some issues I saw on a multi-GPU system, where `GenTextures` ended up being called on the last current context, which if it was on the other GPU, caused this `GlesTexture` to be using the same texture ID as whatever other texture was assigned the same ID.
cmeissl
approved these changes
Jun 2, 2025
ids1024
added a commit
to pop-os/cosmic-comp
that referenced
this pull request
Jun 2, 2025
Drakulix
pushed a commit
to pop-os/cosmic-comp
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unwrap_or_else()call here inimport_shm_buffer()has a call toself.gl.GenTextures(), butself.egl.make_current()was only being called in the next block.It appears this was the cause of some issues I saw on a multi-GPU system, where
GenTexturesended up being called on the last current context, which if it was on the other GPU, caused thisGlesTextureto be using the same texture ID as whatever other texture was assigned the same ID.