Skip to content

feat: allow hotcuts while using transition property #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mint-dewit merged 6 commits into from
Mar 7, 2026
Merged

feat: allow hotcuts while using transition property #46

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
621b29c
feat: allow hotcuts while using transition property
mint-dewit Feb 24, 2026
f42514a
chore: guard against missing props
mint-dewit Feb 24, 2026
7676b61
chore: allow setting preview when program is unchanged
mint-dewit Feb 24, 2026
6b12f64
chore: diff transition for USK & DSK
mint-dewit Mar 7, 2026
454d19e
chore: fix tests
mint-dewit Mar 7, 2026
938cb38
chore: skip keyer transitions if ME doesn't diff
mint-dewit Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/resolvers/__tests__/downstreamKeyer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const fullDiff: Required<DiffDownstreamKeyer> = {
}

test('Unit: Downstream keyer: same state gives no commands', function () {
const commands = resolveDownstreamKeyerState(DSK1, DSK1, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK1, fullDiff)
expect(commands).toHaveLength(0)
})

Expand All @@ -38,7 +38,7 @@ test('Unit: Downstream keyer: auto and onAir commands', function () {
isAuto: true,
}

const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(2)

const firstCommand = commands[0] as Commands.DownstreamKeyOnAirCommand
Expand All @@ -63,7 +63,7 @@ test('Unit: Downstream keyer: sources', function () {
DSK2[0].sources.fillSource = 1
DSK2[1].sources.cutSource = 2

const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(2)

const firstCommand = commands[0] as Commands.DownstreamKeyFillSourceCommand
Expand All @@ -86,7 +86,7 @@ test('Unit: Downstream keyer: sources', function () {

test('Unit: Downstream keyer: rate', function () {
DSK2[0].properties.rate = 50
const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(1)

const firstCommand = commands[0] as Commands.DownstreamKeyRateCommand
Expand All @@ -100,7 +100,7 @@ test('Unit: Downstream keyer: rate', function () {

test('Unit: Downstream keyer: tie', function () {
DSK2[0].properties.tie = true
const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(1)

const firstCommand = commands[0] as Commands.DownstreamKeyTieCommand
Expand All @@ -117,7 +117,7 @@ test('Unit: Downstream keyer: properties', function () {
DSK2[0].properties.clip = 500
DSK2[0].properties.gain = 50
DSK2[0].properties.invert = true
const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(1)

const firstCommand = commands[0] as Commands.DownstreamKeyGeneralCommand
Expand All @@ -143,7 +143,7 @@ test('Unit: Downstream keyer: mask', function () {
left: 3,
right: 4,
}
const commands = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
const { commands } = resolveDownstreamKeyerState(DSK1, DSK2, fullDiff)
expect(commands).toHaveLength(1)

const firstCommand = commands[0] as Commands.DownstreamKeyMaskCommand
Expand Down
Loading
Loading