chore: refactor vizmse device to state handler SOFIE-2498#347
Draft
Julusian wants to merge 6 commits into
Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #347 +/- ##
=============================================
+ Coverage 56.75% 61.46% +4.71%
=============================================
Files 130 132 +2
Lines 10111 10073 -38
Branches 2459 2370 -89
=============================================
+ Hits 5738 6191 +453
+ Misses 4371 3880 -491
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests are not fully updated to the new format, so are failing.
The implementation has not been tested yet, due to lack of direct access to a viz engine/mse.
About the Contributor
Type of Contribution
This is a:
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
Current Behavior
New Behavior
Testing Instructions
Other Information
Status