Feat: Improve json schema#407
Open
rjmunro wants to merge 2 commits into
Open
Conversation
Julusian
reviewed
Nov 13, 2025
Member
Julusian
left a comment
There was a problem hiding this comment.
I'm not sure that this should say run "yarn generate-schema-types" because that name will vary depending on where this is used.
For these schemas inside of the tsr repository that name is correct, but anyone making a tsr plugin will be using the same tsr-schema-types tool through whatever script they want. It may or may not be yarn generate-schema-types for them, and may not even be yarn
But I like including the file path in the banner
3d2f970 to
4410393
Compare
* Show path to source file * Show actual yarn command to run to update
Without this, VSCode warns that $schema is not allowed.
4410393 to
2bfc824
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a Code improvement
Current Behavior
When trying to make changes to
packages/timeline-state-resolver-types/src/generated/atem.ts, I couldn't immediately work out what I had to change to affect the file.Eventually I found
packages/timeline-state-resolver/src/integrations/atem/$schemas/mappings.json, but I was getting a warning from VSCode telling me that the$schemaproperty itself wasn't allowed in the schema.New Behavior
$schemais allowed in the schemaTesting Instructions
Really only comments have changed.
Other Information
Status