feat: visca commands on timeline#438
Draft
Julusian wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Julusian
force-pushed
the
feat/visca-timeline
branch
from
cd7d0c6 to
52d7748
Compare
Julusian
force-pushed
the
feat/visca-timeline
branch
from
52d7748 to
a76c777
Compare
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/timeline-state-resolver/src/integrations/viscaOverIP/state.ts`:
- Around line 33-40: convertStateToVisca currently only filters by device type,
which can cause cross-device contamination when multiple VISCA_OVER_IP devices
share mappings; update convertStateToVisca to additionally check deviceId so
only layers mapped to the target device are processed. Modify the function
(convertStateToVisca) to accept a deviceId parameter or read deviceId from
this.context, then when iterating tlObject and resolving mapping
(mappings[tlObject.layer]), validate mapping.deviceId === deviceId along with
the existing checks (mapping && mapping.device === DeviceType.VISCA_OVER_IP &&
tlObject.content.deviceType === DeviceType.VISCA_OVER_IP) before processing the
tlObject. Ensure you handle undefined mapping.deviceId safely and add/update
tests for multiple VISCA_OVER_IP devices to prevent regressions.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/timeline-state-resolver-types/src/__tests__/__snapshots__/index.spec.ts.snapis excluded by!**/*.snappackages/timeline-state-resolver-types/src/generated/viscaOverIP.tsis excluded by!**/generated/**packages/timeline-state-resolver/src/__tests__/__snapshots__/index.spec.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (14)
packages/timeline-state-resolver-api/$schemas/mapping-schema.jsonpackages/timeline-state-resolver-types/src/index.tspackages/timeline-state-resolver-types/src/integrations/viscaOverIP.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/$schemas/mappings.jsonpackages/timeline-state-resolver/src/integrations/viscaOverIP/__tests__/diff.spec.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/__tests__/state.spec.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/connection/commands/visca/focusCommand.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/connection/commands/visca/panTiltDriveCommand.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/connection/commands/visca/presetCommand.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/connection/commands/visca/zoomCommand.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/connection/lib/socket.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/diff.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/index.tspackages/timeline-state-resolver/src/integrations/viscaOverIP/state.ts
Julusian
added
the
contribution from BBC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
New Behavior
The VISCA device exposes functionality as TSR actions, but not on the timeline. This translates relevant portions to be addressable on the timeline too.
Testing Instructions
Other Information
Status