Skip to content

Cppcheck v2.13.0 support #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Cppcheck v2.13.0 support #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 92 additions & 15 deletions cxx-sensors/src/main/resources/cppcheck.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4538,7 +4538,7 @@ Dangerous usage of c_str(). The string is destroyed after the c_str() call so th
</description>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.69 ########### -->
<!-- ########### New in Cppcheck 1.6.9 ########### -->
<rule>
<key>duplicateExpressionTernary</key>
<name>Same expression in both branches of ternary operator</name>
Expand Down Expand Up @@ -4660,7 +4660,7 @@ appropriate C library function.
</description>
<tag>cwe</tag>
</rule>
<!-- ########### New in Cppcheck 1.70 ########### -->
<!-- ########### New in Cppcheck 1.7.0 ########### -->
<rule>
<key>negativeArraySize</key>
<name>Declaration of array with negative size is undefined behaviour</name>
Expand Down Expand Up @@ -4834,7 +4834,7 @@ example 'return a*b;' => 'return (long)a*b'.
<tag>cwe</tag>
<severity>MINOR</severity>
</rule>
<!-- ########### New in Cppcheck 1.72 ########### -->
<!-- ########### New in Cppcheck 1.7.2 ########### -->
<rule>
<key>assignBoolToFloat</key>
<name>Boolean value assigned to floating point variable</name>
Expand Down Expand Up @@ -4883,7 +4883,7 @@ Expression 'x = x++;' depends on order of evaluation of side effects
<tag>cwe</tag>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.73 ########### -->
<!-- ########### New in Cppcheck 1.7.3 ########### -->
<rule>
<key>signedCharArrayIndex</key>
<name>Signed 'char' type used as array index</name>
Expand Down Expand Up @@ -4936,7 +4936,7 @@ switch()?
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.76 ########### -->
<!-- ########### New in Cppcheck 1.7.6 ########### -->
<!-- this warnings is not reported by "cppcheck -errorlist" -->
<rule>
<key>leakUnsafeArgAlloc</key>
Expand Down Expand Up @@ -5021,7 +5021,7 @@ Reading from empty STL container 'var'
<tag>cwe</tag>
<severity>MINOR</severity>
</rule>
<!-- ########### New in Cppcheck 1.77 ########### -->
<!-- ########### New in Cppcheck 1.7.7 ########### -->
<rule>
<key>nullPointerArithmetic</key>
<name>Pointer arithmetic with NULL pointer</name>
Expand Down Expand Up @@ -5100,7 +5100,7 @@ Undefined behaviour: float (1e+100) to integer conversion overflow.
<tag>cwe</tag>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.78 ########### -->
<!-- ########### New in Cppcheck 1.7.8 ########### -->
<rule>
<key>funcArgNamesDifferent</key>
<name>Function 'function' argument 2 names different: declaration 'A' definition 'B'</name>
Expand Down Expand Up @@ -5145,7 +5145,7 @@ The class 'class' has 'operator=' but lack of 'copy constructor'.
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.82 ########### -->
<!-- ########### New in Cppcheck 1.8.2 ########### -->
<rule>
<key>unsafeClassDivZero</key>
<name>Public interface of Class is not safe</name>
Expand Down Expand Up @@ -7506,7 +7506,7 @@ constructor.
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 1.90 ########### -->
<!-- ########### New in Cppcheck 1.9.0 ########### -->
<rule>
<key>constVariable</key>
<name>Variable 'x' can be declared with const</name>
Expand Down Expand Up @@ -7624,7 +7624,7 @@ Unsafe class checking: The const reference member 'UnsafeClass::var' is initiali
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.10 ########### -->
<!-- ########### New in Cppcheck 2.1.0 ########### -->
<rule>
<key>invalidContainerLoop</key>
<name>Calling 'erase' while iterating the container is invalid</name>
Expand Down Expand Up @@ -7691,7 +7691,7 @@ Iterator 'it' from different container 'v1' are used together.
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.41 ########### -->
<!-- ########### New in Cppcheck 2.4.1 ########### -->
<rule>
<key>danglingTempReference</key>
<name>Using reference to dangling temporary</name>
Expand Down Expand Up @@ -7837,7 +7837,7 @@ be used in code that is removed by the preprocessor. Should this be a
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.50 ########### -->
<!-- ########### New in Cppcheck 2.5.0 ########### -->
<rule>
<key>assignmentInCondition</key>
<name>Suspicious assignment in condition. Condition 'x=y' is always true</name>
Expand Down Expand Up @@ -7867,7 +7867,7 @@ https://isocpp.org/wiki/faq/exceptions#throw-without-an-object
<tag>cwe</tag>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.60 ########### -->
<!-- ########### New in Cppcheck 2.6.0 ########### -->
<rule>
<key>compareValueOutOfTypeRangeError</key>
<name>Comparing expression of type 'unsigned char' against value 256</name>
Expand Down Expand Up @@ -7954,7 +7954,7 @@ missing return statement
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.70 ########### -->
<!-- ########### New in Cppcheck 2.7.0 ########### -->
<rule>
<key>missingMemberCopy</key>
<name>Member variable 'classname::varnamepriv' is not assigned in the copy constructor</name>
Expand All @@ -7970,7 +7970,7 @@ constructor. Should it be moved?
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<!-- ########### New in Cppcheck 2.90 ########### -->
<!-- ########### New in Cppcheck 2.9.0 ########### -->
<rule>
<key>constParameterCallback</key>
<name>Parameter 'x' can be declared with const, however it seems that 'f' is a callback function</name>
Expand All @@ -7979,6 +7979,83 @@ constructor. Should it be moved?
]]></description>
<severity>MINOR</severity>
</rule>
<!-- ########### New in Cppcheck 2.13.0 ########### -->
<rule>
<key>constParameterPointer</key>
<name>Parameter 'x' can be declared with const</name>
<description>
<![CDATA[
Parameter 'x' can be declared with const
]]>
</description>
<severity>MINOR</severity>
</rule>
<rule>
<key>constParameterReference</key>
<name>Parameter 'x' can be declared with const</name>
<description>
<![CDATA[
Parameter 'x' can be declared with const
]]>
</description>
<severity>MINOR</severity>
</rule>
<rule>
<key>constVariablePointer</key>
<name>Variable 'x' can be declared with const</name>
<description>
<![CDATA[
Variable 'x' can be declared with const
]]>
</description>
<severity>MINOR</severity>
</rule>
<rule>
<key>constVariableReference</key>
<name>Variable 'x' can be declared with const</name>
<description>
<![CDATA[
Variable 'x' can be declared with const
]]>
</description>
<severity>MINOR</severity>
</rule>
<rule>
<key>knownPointerToBool</key>
<name>Pointer expression 'p' converted to bool is always true</name>
<description>
<![CDATA[
Pointer expression 'p' converted to bool is always true.
]]>
</description>
<severity>MINOR</severity>
</rule>
<rule>
<key>pointerOutOfBoundsCond</key>
<name>Pointer arithmetic overflow</name>
<description>
<![CDATA[
<p>
Pointer arithmetic overflow.
</p>
<h2>References</h2>
<p><a href="https://cwe.mitre.org/data/definitions/758.html" target="_blank">CWE-758</a></p>
]]>
</description>
<tag>cwe</tag>
<severity>MINOR</severity>
<type>BUG</type>
</rule>
<rule>
<key>useStandardLibrary</key>
<name>Consider using memcpy instead of loop</name>
<description>
<![CDATA[
Consider using memcpy instead of loop.
]]>
</description>
<severity>MINOR</severity>
</rule>
<!-- ########### Internal Cppcheck errors (not in errorlist) ########### -->
<rule>
<key>internalAstError</key>
Expand Down
2 changes: 1 addition & 1 deletion cxx-sensors/src/test/java/org/sonar/cxx/sensors/cppcheck/CxxCppCheckRuleRepositoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void createRulesTest() {
def.define(context);

RulesDefinition.Repository repo = context.repository(CxxCppCheckRuleRepository.KEY);
assertThat(repo.rules()).hasSize(674);
assertThat(repo.rules()).hasSize(681);
}

}
Binary file modified cxx-sensors/src/tools/cwec_latest.xml.zip
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions cxx-sensors/src/tools/generate_cppcheck_resources.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ SET SCRIPT_DIR=%~dp0
SET CPPCHECK_DIR=C:\Program Files\Cppcheck\
SET PYTHON_DIR=C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\

SET CPPCHECK_LIBRARY_ARGS=--library=avr.cfg --library=bento4.cfg --library=boost.cfg --library=bsd.cfg --library=cairo.cfg --library=cppunit.cfg --library=dpdk.cfg --library=embedded_sql.cfg --library=gnu.cfg --library=googletest.cfg --library=gtk.cfg --library=kde.cfg --library=libcerror.cfg --library=libcurl.cfg --library=libsigc++.cfg --library=lua.cfg --library=mfc.cfg --library=microsoft_atl.cfg --library=microsoft_sal.cfg --library=microsoft_unittest.cfg --library=motif.cfg --library=nspr.cfg --library=opencv2.cfg --library=opengl.cfg --library=openmp.cfg --library=openssl.cfg --library=posix.cfg --library=python.cfg --library=qt.cfg --library=ruby.cfg --library=sdl.cfg --library=sfml.cfg --library=sqlite3.cfg --library=std.cfg --library=tinyxml2.cfg --library=vcl.cfg --library=windows.cfg --library=wxwidgets.cfg --library=zlib.cfg
SET CPPCHECK_LIBRARY_ARGS=--library=avr.cfg --library=bento4.cfg --library=boost.cfg --library=bsd.cfg --library=cairo.cfg --library=cppcheck-lib.cfg --library=cppunit.cfg --library=dpdk.cfg --library=embedded_sql.cfg --library=emscripten.cfg --library=ginac.cfg --library=gnu.cfg --library=googletest.cfg --library=gtk.cfg --library=icu.cfg --library=kde.cfg --library=libcerror.cfg --library=libcurl.cfg --library=libsigc++.cfg --library=lua.cfg --library=mfc.cfg --library=microsoft_atl.cfg --library=microsoft_sal.cfg --library=microsoft_unittest.cfg --library=motif.cfg --library=nspr.cfg --library=ntl.cfg --library=opencv2.cfg --library=opengl.cfg --library=openmp.cfg --library=openssl.cfg --library=pcre.cfg --library=posix.cfg --library=python.cfg --library=qt.cfg --library=ruby.cfg --library=sdl.cfg --library=sfml.cfg --library=sqlite3.cfg --library=std.cfg --library=tinyxml2.cfg --library=vcl.cfg --library=windows.cfg --library=wxsqlite3.cfg --library=wxsvg.cfg --library=wxwidgets.cfg --library=zlib.cfg

rem download cwec_latest.xml.zip and extract it to unzip cwec_vx.y.xml
rem wget https://cwe.mitre.org/data/xml/cwec_latest.xml.zip --output-document=cwec_latest.xml.zip && unzip -j -o cwec_latest.xml.zip
Expand All @@ -16,7 +16,7 @@ ECHO create Cppcheck errorlist cppcheck-errorlist.xml...
"%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 > cppcheck-errorlist.xml

ECHO create SonarQube rules file cppcheck.xml...
"%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 | "%PYTHON_DIR%python.exe" cppcheck_createrules.py rules cwec_v4.9.xml > cppcheck.xml
"%CPPCHECK_DIR%cppcheck.exe" %CPPCHECK_LIBRARY_ARGS% --errorlist --xml-version=2 | "%PYTHON_DIR%python.exe" cppcheck_createrules.py rules cwec_v4.13.xml > cppcheck.xml

ECHO create cppcheck-comparison.md...
"%PYTHON_DIR%python.exe" utils_createrules.py comparerules "%SCRIPT_DIR%\..\main\resources\cppcheck.xml" .\cppcheck.xml > cppcheck-comparison.md