Skip to content

Update LLVM 19 support to 19.1.0 release (first stable release) #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

opajonk
Copy link

@opajonk opajonk commented Oct 17, 2024

  • use tag llvmorg-19.1.0
  • new ClangTidy rules:
    • boost-use-ranges
    • bugprone-crtp-constructor-accessibility
    • bugprone-pointer-arithmetic-on-polymorphic-object
    • bugprone-return-const-ref-from-parameter
    • bugprone-suspicious-stringview-data-usage
    • cert-ctr56-cpp
    • cert-int09-c
    • clang-analyzer-cplusplus.ArrayDelete
    • clang-analyzer-optin.taint.TaintedAlloc
    • clang-analyzer-security.PutenvStackArray
    • clang-analyzer-security.SetgidSetuidOrder
    • clang-analyzer-unix.BlockInCriticalSection
    • clang-analyzer-unix.Stream
    • linuxkernel-must-check-errs
    • misc-use-internal-linkage
    • modernize-min-max-use-initializer-list
    • modernize-use-designated-initializers
    • modernize-use-ranges
    • modernize-use-std-format
    • readability-enum-initial-value
    • readability-math-missing-parentheses
    • readability-use-std-min-max
    • clang-diagnostic-aarch64-sme-attributes
    • clang-diagnostic-alias-template-in-declaration-name
    • clang-diagnostic-arm-interrupt-vfp-clobber
    • clang-diagnostic-bounds-safety-counted-by-elt-type-unknown-size
    • clang-diagnostic-c++23-attribute-extensions
    • clang-diagnostic-c++23-compat
    • clang-diagnostic-c++2c-compat
    • clang-diagnostic-c2y-extensions
    • clang-diagnostic-cast-function-type-mismatch
    • clang-diagnostic-dangling-assignment
    • clang-diagnostic-dangling-assignment-gsl
    • clang-diagnostic-deprecated-no-relaxed-template-template-args
    • clang-diagnostic-deprecated-ofast
    • clang-diagnostic-explicit-specialization-storage-class
    • clang-diagnostic-extractapi-misuse
    • clang-diagnostic-format-signedness
    • clang-diagnostic-friend-enum
    • clang-diagnostic-function-effects
    • clang-diagnostic-higher-precision-fp
    • clang-diagnostic-hlsl-availability
    • clang-diagnostic-installapi-violation
    • clang-diagnostic-missing-designated-field-initializers
    • clang-diagnostic-missing-include-dirs
    • clang-diagnostic-missing-template-arg-list-after-template-kw
    • clang-diagnostic-mix-packoffset
    • clang-diagnostic-nvcc-compat
    • clang-diagnostic-openacc-deprecated-clause-alias
    • clang-diagnostic-openacc-self-if-potential-conflict
    • clang-diagnostic-pch-vfs-diff
    • clang-diagnostic-pre-c11-compat
    • clang-diagnostic-pre-c11-compat-pedantic
    • clang-diagnostic-pre-c2y-compat
    • clang-diagnostic-pre-c2y-compat-pedantic
    • clang-diagnostic-ptrauth-null-pointers
    • clang-diagnostic-return-mismatch
    • clang-diagnostic-strict-primary-template-shadow
    • clang-diagnostic-template-in-declaration-name
    • clang-diagnostic-tentative-definition-array
    • clang-diagnostic-unsafe-buffer-usage-in-container
  • new Clang Static Analyzer rules:
    • cplusplus.ArrayDelete
    • optin.taint.TaintedAlloc
    • security.PutenvStackArray
    • security.SetgidSetuidOrder
    • unix.BlockInCriticalSection
    • unix.Stream
  • Added shebangs and executable flags to a few tool scripts
  • Updated some old Clang-Tidy rule documentation to newer variants provided by LLVM

Resolves #2778


This change is Reviewable

@opajonk opajonk marked this pull request as ready for review October 17, 2024 10:46
@guwirth guwirth added this to the 2.2.0 milestone Oct 17, 2024
@guwirth
Copy link
Collaborator

guwirth commented Oct 17, 2024

Hello @opajonk, thanks a lot for providing this update. I will wait for CI results ..

@guwirth guwirth merged commit dafec72 into SonarOpenCommunity:master Oct 17, 2024
12 checks passed
@opajonk opajonk deleted the update_clang-tidy_to_19.1.0_release branch October 17, 2024 15:12
@guwirth
Copy link
Collaborator

guwirth commented Oct 17, 2024

@opajonk you can download the JAR files from artifacts from here
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/11387549150

@opajonk
Copy link
Author

opajonk commented Oct 18, 2024

@opajonk you can download the JAR files from artifacts from here https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/11387549150

Would it be possible to create a beta-release with this included? Apparently, we have no possibility to install such "snapshots" here...

@opajonk
Copy link
Author

opajonk commented Oct 23, 2024

@guwirth Would it be possible to create a beta-release with this included? Apparently, we have no possibility to install such "snapshots" here...

@guwirth
Copy link
Collaborator

guwirth commented Oct 24, 2024

@opajonk
Copy link
Author

opajonk commented Oct 24, 2024

@opajonk what about using https://github.com/SonarOpenCommunity/sonar-cxx/releases/tag/latest-snapshot?

@guwirth For our production SQ-server IT wants to have at least a stable tag...

@guwirth
Copy link
Collaborator

guwirth commented Oct 25, 2024

@opajonk please try with https://github.com/SonarOpenCommunity/sonar-cxx/releases/tag/cxx-2.2.0-beta.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update Clang-Tidy support to released version 19.1.0
2 participants