Create rule S126: "if ... elif" constructs should end with "else" clauses #5210
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
denis-troller
changed the title
|
sebastien-marichal
requested changes
Aug 13, 2025
rules/S126/shell/rule.adoc
Outdated
Comment on lines
9
to
32
| === Noncompliant code example | ||
|
|
||
| [source,bash,diff-id=1,diff-type=noncompliant] | ||
| ---- | ||
| if [[ $x -eq 0 ]]; then | ||
| do_something | ||
| elif [[ $x -eq 1 ]]; then | ||
| do_something_else | ||
| fi | ||
| ---- | ||
|
|
||
| === Compliant solution | ||
|
|
||
| [source,bash,diff-id=1,diff-type=compliant] | ||
| ---- | ||
| if [[ $x -eq 0 ]]; then | ||
| do_something | ||
| elif [[ $x -eq 1 ]]; then | ||
| do_something_else | ||
| else | ||
| echo "Unexpected value: $x" | ||
| exit 1 | ||
| fi | ||
| ---- |
There was a problem hiding this comment.
Suggested change
| === Noncompliant code example | |
| [source,bash,diff-id=1,diff-type=noncompliant] | |
| ---- | |
| if [[ $x -eq 0 ]]; then | |
| do_something | |
| elif [[ $x -eq 1 ]]; then | |
| do_something_else | |
| fi | |
| ---- | |
| === Compliant solution | |
| [source,bash,diff-id=1,diff-type=compliant] | |
| ---- | |
| if [[ $x -eq 0 ]]; then | |
| do_something | |
| elif [[ $x -eq 1 ]]; then | |
| do_something_else | |
| else | |
| echo "Unexpected value: $x" | |
| exit 1 | |
| fi | |
| ---- | |
| == How to fix it | |
| === Code examples | |
| ==== Noncompliant code example | |
| [source,bash,diff-id=1,diff-type=noncompliant] | |
| ---- | |
| if [[ $x -eq 0 ]]; then | |
| do_something | |
| elif [[ $x -eq 1 ]]; then | |
| do_something_else | |
| fi | |
| ---- | |
| ==== Compliant solution | |
| [source,bash,diff-id=1,diff-type=compliant] | |
| ---- | |
| if [[ $x -eq 0 ]]; then | |
| do_something | |
| elif [[ $x -eq 1 ]]; then | |
| do_something_else | |
| else | |
| echo "Unexpected value: $x" | |
| exit 1 | |
| fi | |
| ---- |
sebastien-marichal
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: