Create rule S131: "case" statements should have "*)" clauses #5212
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
denis-troller
changed the title
|
yassin-kammoun-sonarsource
force-pushed
the
rule/S131-add-shell
branch
from
303f060 to
0990ea4
Compare
|
|
| === Noncompliant code example | ||
|
|
||
| [source,bash,diff-id=1,diff-type=noncompliant] | ||
| ---- | ||
| case "$param" in # missing default clause | ||
| 0) | ||
| do_something | ||
| ;; | ||
| 1) | ||
| do_something_else | ||
| ;; | ||
| esac | ||
|
|
||
| case "$param" in | ||
| *) # default clause should be the last one | ||
| error | ||
| ;; | ||
| 0) | ||
| do_something | ||
| ;; | ||
| 1) | ||
| do_something_else | ||
| ;; | ||
| esac | ||
| ---- | ||
|
|
||
| === Compliant solution |
There was a problem hiding this comment.
| === Noncompliant code example | |
| [source,bash,diff-id=1,diff-type=noncompliant] | |
| ---- | |
| case "$param" in # missing default clause | |
| 0) | |
| do_something | |
| ;; | |
| 1) | |
| do_something_else | |
| ;; | |
| esac | |
| case "$param" in | |
| *) # default clause should be the last one | |
| error | |
| ;; | |
| 0) | |
| do_something | |
| ;; | |
| 1) | |
| do_something_else | |
| ;; | |
| esac | |
| ---- | |
| === Compliant solution | |
| == How to fix it | |
| === Code examples | |
| ==== Noncompliant code example | |
| [source,bash,diff-id=1,diff-type=noncompliant] | |
| ---- | |
| case "$param" in # missing default clause | |
| 0) | |
| do_something | |
| ;; | |
| 1) | |
| do_something_else | |
| ;; | |
| esac | |
| case "$param" in | |
| *) # default clause should be the last one | |
| error | |
| ;; | |
| 0) | |
| do_something | |
| ;; | |
| 1) | |
| do_something_else | |
| ;; | |
| esac | |
| ---- | |
| ==== Compliant solution |
| case "$param" in | ||
| *) # default clause should be the last one | ||
| error | ||
| ;; | ||
| 0) | ||
| do_something | ||
| ;; | ||
| 1) | ||
| do_something_else | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
For the diff to be nice I would suggest to either remove this example or put into its own code block.
| case "$param" in | ||
| *) # default clause should be the last one | ||
| error | ||
| ;; | ||
| 0) | ||
| do_something | ||
| ;; | ||
| 1) | ||
| do_something_else | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
I am not sure why this case is part of this rule.
Isn't the rule only about the missing default clause?
sebastien-marichal
changed the title
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: