Skip to content

Modify S4790: Update Swift code examples (SONARSWIFT-677) #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modify S4790: Update Swift code examples (SONARSWIFT-677) #5217

wants to merge 2 commits into from

Conversation

pierre-loup-tristant-sonarsource
Copy link
Contributor

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource commented Jul 16, 2025 •
edited by jira bot
Loading

SONARSWIFT-675

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Modify S4790: Update Swift code examples (SONARSWIFT-675) Modify S4790: Update Swift code examples (SONARSWIFT-677) Jul 16, 2025
egon-okerman-sonarsource
egon-okerman-sonarsource reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include all frameworks, as we usually do?

@pierre-loup-tristant-sonarsource
Copy link
Contributor Author

pierre-loup-tristant-sonarsource commented Jul 23, 2025 •
edited
Loading

Should this include all frameworks, as we usually do?

Do you mean context specific code examples ? It's only possible for vulnerabilities right?

@egon-okerman-sonarsource
Copy link
Contributor

Some hotspots still have context specific examples, but they're not split up like they are in vulnerabilities. For example: https://sonarsource.github.io/rspec/#/rspec/S6291/kotlin:~:text=Sensitive%20Code%20Example,getInstance(config)%20//%20Sensitive

@pierre-loup-tristant-sonarsource
Copy link
Contributor Author

I added code examples for CommonCrypto. I will not cover IDZSwiftCommonCrypto and CryptoSwift since they are rarely used.

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

egon-okerman-sonarsource
egon-okerman-sonarsource approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egon-okerman-sonarsource egon-okerman-sonarsource egon-okerman-sonarsource approved these changes

Assignees
No one assigned
Labels
swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierre-loup-tristant-sonarsource @egon-okerman-sonarsource