Skip to content

Conversation

@loic-joly-sonarsource
Copy link
Contributor

  • Parse C++ Core Guidelines to generate a list of asciidoc attributes
  • Automatically include external references attributes at the start of each rule description
  • Unresolved attribute entries are now an error

…urces

* Parse C++ Core Guidelines to generate a list of asciidoc attributes
* Automatically include external references attributes at the start of each rule description
* Unresolved attribute entries are now an error
@loic-joly-sonarsource loic-joly-sonarsource added the rspec system Related to handling of rspecs (scripts, doc...) label Dec 17, 2025
@hashicorp-vault-sonar-prod
Copy link
Contributor

hashicorp-vault-sonar-prod bot commented Dec 17, 2025

RULEAPI-855

if asciidoctor --failure-level=WARNING -o /dev/null rules/*/*/tmp*.adoc; then
if asciidoctor -a rspecator-view --failure-level=WARNING -o /dev/null rules/*/*/tmp*.adoc; then
if asciidoctor -a attribute-missing=warn --failure-level=WARNING --verbose --trace -o /dev/null rules/*/*/tmp*.adoc; then
if asciidoctor -a rspecator-view --failure-level=WARNING --verbose --trace -o /dev/null rules/*/*/tmp*.adoc; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if asciidoctor -a rspecator-view --failure-level=WARNING --verbose --trace -o /dev/null rules/*/*/tmp*.adoc; then
if asciidoctor -a rspecator-view --failure-level=WARNING --verbose --trace -o /dev/null rules/*/*/tmp*.adoc; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good thing is that everything is homogeneous now. The bad thing is that it is all homogeneously broken, because the markdown anchors you used do not work in Github. We instead need to use the anchors based on the text of the title.
For example, the first link should be https://github.com/isocpp/CppCoreGuidelines/blob/e49158a/CppCoreGuidelines.md#in0-dont-panic
I'm not sure if the simplest solution is to take the text of the title, replace spaces with - and remove everything that is not [A-Za-z0-9_]; or if we should rather download the html version and look at the generated ids.

@sonarqube-next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rspec system Related to handling of rspecs (scripts, doc...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants