Fix S1117 FP: Field/property instances are not accessible from static methods

[cristian-ambrosini-sonarsource]

The rule needs to distinguish between instance and static members.
Primary constructor parameters and instance fields/properties can only be shadowed in instance methods.

class Repro_XXXX(int primaryCtorParam)
{
    private int instanceField = 1;
    private int instanceProperty { get; set; } = 1;
    private static int staticField = 1;
    private static int staticProperty = 1;

    public static void StaticMethod()
    {
        var instanceField = 2; // Noncompliant FP (instance field is not accessible from static method)
        var instanceProperty = 2; // Noncompliant FP (instance property is not accessible from static method)
        var primaryCtorParam = 2; // Noncompliant FP (primary ctor parameter is not accessible from static method)

        var staticField = 2; // Noncompliant
        var staticProperty = 2; // Noncompliant
    }
}

[cristian-ambrosini-sonarsource]

@martin-strecker-sonarsource: a SemanticModel.IsAccessible check is missing:
var fieldsAndProperties = members.Where(x => x is IPropertySymbol or IFieldSymbol).ToList();

Private fields/properties are accessible from within the declaring type but not derived types
protected/public fields/properties are accessible from the declaring and derived types.

See the original comment here.

[hankovich]

Any progress on this? Just got this warning after bumping package from 9.6.0.74858 to 9.21.0.86780

[cristian-ambrosini-sonarsource]

Hi @hankovich, no progress on this yet.
We have a few hardening sprints in the next months and the issue has high priority, I think there's a good chance it will be tackled. Up until then, I suggest you mark it as FP.