Skip to content

Deprecate S6803 #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
costin-zaharia-sonarsource merged 3 commits into from
Apr 24, 2024
Merged

Deprecate S6803 #9189

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
632e12d
update rspec and remove from sonar-way
mary-georgiou-sonarsource Apr 23, 2024
1423cfb
mark code as obsolete
mary-georgiou-sonarsource Apr 23, 2024
7764bf0
Apply comments
mary-georgiou-sonarsource Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion analyzers/rspec/cs/S6803.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<p>Component parameters can only receive query parameter values in routable components with an @page directive.</p>
<p>&lt;p&gt;This rule is deprecated, and will eventually be removed.&lt;/p&gt; Component parameters can only receive query parameter values in
routable components with an @page directive.</p>
<h2>Why is this an issue?</h2>
<p><a
href="https://learn.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.components.supplyparameterfromqueryattribute">SupplyParameterFromQuery</a>
Expand Down
2 changes: 1 addition & 1 deletion analyzers/rspec/cs/S6803.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "Parameters with SupplyParameterFromQuery attribute should be used only in routable components",
"type": "CODE_SMELL",
"status": "ready",
"status": "deprecated",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "5min"
Expand Down
1 change: 0 additions & 1 deletion analyzers/rspec/cs/Sonar_way_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@
"S6797",
"S6798",
"S6800",
"S6803",
"S6930",
"S6931",
"S6934",
Expand Down
1 change: 1 addition & 0 deletions analyzers/src/SonarAnalyzer.CSharp/Rules/BlazorQueryParameterRoutableComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

namespace SonarAnalyzer.Rules.CSharp;

[Obsolete("This rule has been deprecated since 9.25")]
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public sealed class BlazorQueryParameterRoutableComponent : SonarDiagnosticAnalyzer
{
Expand Down