-
Notifications
You must be signed in to change notification settings - Fork 160
SQSCANGHA-94 Update version update logic #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
csaba-feher-sonarsource
merged 1 commit into
master
from
task/cfeher/SQSCANGHA-89-Fix-version-upgrade
May 5, 2025
Merged
SQSCANGHA-94 Update version update logic #188
csaba-feher-sonarsource
merged 1 commit into
master
from
task/cfeher/SQSCANGHA-89-Fix-version-upgrade
May 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryju
approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how it is helping the original concern of using write permission, but at least this is a nice refactoring, makes things cleaner.
ab84207
to
d7e162a
Compare
luketainton
pushed a commit
to luketainton/roboluke-tasks
that referenced
this pull request
May 6, 2025
…0 (#349) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.1.0` -> `v5.2.0` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v5.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.2.0) [Compare Source](SonarSource/sonarqube-scan-action@v5.1.0...v5.2.0) ##### What's Changed - SQSCANGHA-90 remove mend dead conf by [@​pierre-guillot-gh](https://github.com/pierre-guillot-gh) in SonarSource/sonarqube-scan-action#184 - SQSCANGHA-89 Attempt to fix command injection by [@​henryju](https://github.com/henryju) in SonarSource/sonarqube-scan-action#186 - SQSCANGHA-93 Fix madhead/semver-utils' version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#187 - SQSCANGHA-94 Update version update logic by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#188 - SQSCANGHA-92 Validate scanner version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#189 **Full Changelog**: SonarSource/sonarqube-scan-action@v5...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4wLjkiLCJ1cGRhdGVkSW5WZXIiOiI0MC4wLjkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/349 Co-authored-by: Renovate [BOT] <[email protected]> Co-committed-by: Renovate [BOT] <[email protected]>
luketainton
pushed a commit
to luketainton/gha-workflows
that referenced
this pull request
Aug 15, 2025
…0 (#26) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.1.0` -> `v5.2.0` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v5.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.2.0) [Compare Source](SonarSource/sonarqube-scan-action@v5.1.0...v5.2.0) #### What's Changed - SQSCANGHA-90 remove mend dead conf by [@​pierre-guillot-gh](https://github.com/pierre-guillot-gh) in SonarSource/sonarqube-scan-action#184 - SQSCANGHA-89 Attempt to fix command injection by [@​henryju](https://github.com/henryju) in SonarSource/sonarqube-scan-action#186 - SQSCANGHA-93 Fix madhead/semver-utils' version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#187 - SQSCANGHA-94 Update version update logic by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#188 - SQSCANGHA-92 Validate scanner version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#189 **Full Changelog**: SonarSource/sonarqube-scan-action@v5...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4wLjkiLCJ1cGRhdGVkSW5WZXIiOiI0MC4wLjkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tainton.uk/actions/gha-workflows/pulls/26 Reviewed-by: Luke Tainton <[email protected]> Co-authored-by: Renovate [BOT] <[email protected]> Co-committed-by: Renovate [BOT] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQSCANGHA-94
Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".
With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:
We will try to give you feedback on your contribution as quickly as possible.
Thank You!
The SonarSource Team