Fixing timerdone bug #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miDeb
approved these changes
Jul 17, 2025
Member
miDeb
left a comment
miDeb
left a comment
There was a problem hiding this comment.
Looks good! Might also be a good case to write a test for?
Member
Author
|
Yes it would be. but then i'd have to mock the ECUISocket, which is a PITA. I'll do it some other time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that a timer-sync message was sent after the timer-done message.
I moved the timer-done to the point where the actual sequence is finished and not where we tell it to finish in the next iteration.
The bugfix was tested on the hardware and the sequences now immediatly end at sequence end and abort.
Also I apparently didn't push the "TEST": "ON" setting in the cmake presets so I added it here.