#1002 fix eagerly cacheable function to support query field from v5 s…#1006
Merged
Conversation
tommysitu
commented
Feb 8, 2022
| this.Method == nil || len(this.Method) != 1 || this.Method[0].Matcher != matchers.Exact || | ||
| this.Path == nil || len(this.Path) != 1 || this.Path[0].Matcher != matchers.Exact || | ||
| this.DeprecatedQuery == nil || len(this.DeprecatedQuery) != 1 || this.DeprecatedQuery[0].Matcher != matchers.Exact || | ||
| this.DeprecatedQuery != nil && len(this.DeprecatedQuery) == 1 && this.DeprecatedQuery[0].Matcher != matchers.Exact || |
Member
Author
There was a problem hiding this comment.
only check this deprecated field when it's present
tommysitu
commented
Feb 8, 2022
Comment on lines
+225
to
+234
| if this.Query != nil && len(*this.Query) > 0 { | ||
| for key, valueMatchers := range *this.Query { | ||
| for _, valueMatcher := range valueMatchers { | ||
| if valueMatcher.Matcher != matchers.Exact { | ||
| return nil | ||
| } | ||
| query[key] = []string{valueMatcher.Value.(string)} | ||
| } | ||
| } | ||
| } else if this.DeprecatedQuery != nil && len(this.DeprecatedQuery) == 1 { |
Member
Author
There was a problem hiding this comment.
should check the new query matchers first
tommysitu
force-pushed
the
fix-eagerly-cacheable-check
branch
from
February 8, 2022 23:43
82d76f6 to
8a96e4c
Compare
tommysitu
force-pushed
the
fix-eagerly-cacheable-check
branch
from
February 8, 2022 23:45
8a96e4c to
9da2953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…imulation