Replace deep relative imports with absolute imports #3766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
commented
Mar 13, 2025
| @@ -47,7 +47,7 @@ | |||
|
|
|||
| # the dataset has been downloaded locally | |||
| base_folder = Path("/mnt/data/sam/DataSpikeSorting/") | |||
| np_data_drift = base_folder / 'human_neuropixel" / "Pt02" | |||
| np_data_drift = base_folder / "human_neuropixel" / "Pt02" | |||
There was a problem hiding this comment.
ruff also kept brining up this typo that I couldn't help but correct.... Everything else are automated fixes from ruff.
alejoe91
approved these changes
Mar 13, 2025
|
Fastest merge I've ever seen |
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from discussions in #3027 and #3764, this PR makes (most) imports absolute.
PEP8 and the default ruff and flake-8 rules allow for simple (same folder) relative imports. For now, I've been conservative with changes and left these in.
Did this with a single command:
Let's find out how unsafe these fixes were!