Allow for SortingAnalyzer
or BaseSorter
in plot_*
#3941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from discussion in #3937, this PR allows the user to pass a
SortingAnalyzer
toplot_isi_distribution
.Will also add to
plot_rasters
,plot_unit_presence
andplot_probe_map
. Before I do, is the strategy here fine? I've replace thesorting
argument withsorting_analyzer_or_sorting
. I think most users use this asso won't notice any difference.
For anyone passing
sorting=sorting
, I've deprecated the argument.