Conversation
AAGaming00
force-pushed
the
aa/desktop-routerhook
branch
from
7e040c1 to
fa4c4a7
Compare
AAGaming00
added
enhancement
PartyWumpus
left a comment
PartyWumpus
left a comment
There was a problem hiding this comment.
route patches need UIMode in dfl too. It should be optional and default to BPM for backwards compat prob
| Navigation.CloseSideMenus(); | ||
| setDesktopMenuOpen(false); |
There was a problem hiding this comment.
This shouldn't be needed, we should modify Navigation.CloseSideMenus() to close the desktop menu. Def needed because plugins close side menus too all the time
| @@ -87,10 +105,10 @@ class RouterHook extends Logger { | |||
| this.patchGamepadRouter(); | |||
| break; | |||
| // Not fully implemented yet | |||
| export enum UIMode { | ||
| BigPicture = 4, | ||
| Desktop = 7, | ||
| } |
| export class DeckyRouterState { | ||
| private _routes = new Map<string, RouterEntry>(); | ||
| private _routePatches = new Map<string, Set<RoutePatch>>(); | ||
| // Update when support for new UIModes is added |
There was a problem hiding this comment.
What other UIModes are there? I guess SteamVR might be seperate from BPM?
There was a problem hiding this comment.
I have no idea how vr works but I plan to look into it soon
it'll be interesting as it can run at the same time as the desktop ui
| Navigation.OpenQuickAccessMenu(QuickAccessTab.Decky); | ||
| DeckyPluginLoader.setDesktopMenuOpen(true); |
There was a problem hiding this comment.
Similar to above comment, we could make OpenQuickAccessMenu open the desktop menu but eeh i don't know if any plugins use it, and it only makes sense for the decky tab so not really sure.
|
Noticed while messing aroung, the reorderable list doesn't work properly in desktop mode. Not a shock but it's going to be a little weird to fix i think. |
|
There also tends to just be a general level of jank lol |
AAGaming00
force-pushed
the
aa/desktop-routerhook
branch
2 times, most recently
from
1442381 to
ee39a6f
Compare
works well enough lol
Co-authored-by: Party Wumpus <48649272+PartyWumpus@users.noreply.github.com>
AAGaming00
force-pushed
the
aa/desktop-routerhook
branch
from
ee39a6f to
7e1406c
Compare
|
The sidebar shows up under the store in desktop mode |
This comment has been minimized.
This comment has been minimized.
|
@NinjaHamsters This is a work-in-progress PR and is not guaranteed to be functional or free of issues. Reinstall decky to revert to the stable release. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I resolved conflicts and it works pretty well! 
|
8 participants
Please tick as appropriate:
Description
This PR adds full feature parity between desktop and gamepad UI modes. The styling is a bit rough, but it's fully functional.
Video
Also includes some React DevTools fixes.