-
Notifications
You must be signed in to change notification settings - Fork 164
Closed
Labels
Type/code-qualityIssue that affects code qualityIssue that affects code qualityWarn/api-changeThe APIs were changedThe APIs were changedWarn/breaking-changeThere is a breaking change in the codeThere is a breaking change in the code
Description
Address existing violations of S3872: Parameter names should not duplicate the names of their methods in the codebase and set severity to Warning
in Steeltoe.Debug.ruleset
and Steeltoe.Release.ruleset
.
To find existing violations, enable the rule (see above) and rebuild src/Steeltoe.All.sln
to make them appear in the Output window.
To address the violations, choose from the following on a case-by-case basis:
- Fix the violation by renaming the parameter to something more useful, or
value
if there's nothing to clarify - Suppress the violation in code using
#pragma warning disable/restore
, preceded by a justification comment if not obvious
Metadata
Metadata
Assignees
Labels
Type/code-qualityIssue that affects code qualityIssue that affects code qualityWarn/api-changeThe APIs were changedThe APIs were changedWarn/breaking-changeThere is a breaking change in the codeThere is a breaking change in the code