Skip to content

Drop .Extensions from Steeltoe.Logging namespace #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Nov 1, 2022

Description

Similarly to what we did for Steeltoe.Configuration in #1008, this PR drops ".Extensions" from the Steeltoe.Logging namespace.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware changed the title Drop .Extensions from Steeltoe Logging namespace Drop .Extensions from Steeltoe.Logging namespace Nov 1, 2022
@bart-vmware bart-vmware marked this pull request as ready for review November 1, 2022 16:41
Copy link
Contributor

@dtillman dtillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware merged commit 673fd72 into main Nov 2, 2022
@bart-vmware bart-vmware deleted the drop-extensions-from-logging-namespace branch November 2, 2022 10:20
@TimHess TimHess added this to the 4.0.0-alpha milestone Dec 5, 2022
@bart-vmware bart-vmware added ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Component/Logging Issues related to Dynamic Logging labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Logging Issues related to Dynamic Logging ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants