Update code quality rules #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and construct policies
S6610: "StartsWith" and "EndsWith" overloads that take a "char" should be used instead of the ones that take a "string" with: CA1865/CA1866: Use 'string.Method(char)' instead of 'string.Method(string)' for string with single char Rationale: The CA rules cover more methods. Their refactoring suggestion is only provided when the conversion is safe.
…tionToken parameter to methods that take one
…rameters must come last
…t match namespaces
… results Change severity from Hidden to None for IDE0058: Remove unnecessary expression value Rationale: IDE0058 triggers for everything (producing noise in the Error List), whereas CA1806 is constrained to specific cases.
…gs using string length
…pend(char) for single character strings
… AttributeUsageAttribute
…CurrentThread.ManagedThreadId
…char) instead of String.Contains(string) with single characters
…hen possible for improved performance
…rns untyped data rows
…e too many parameters Only affects release builds, remains at Info severity for debug builds.
|
/azp run Steeltoe.All |
This comment was marked as outdated.
This comment was marked as outdated.
bart-vmware
force-pushed
the
resharper-inspections
branch
2 times, most recently
from
b5fd1b3 to
a3dc658
Compare
bart-vmware
force-pushed
the
resharper-inspections
branch
from
a3dc658 to
cb7c51f
Compare
TimHess
reviewed
Aug 28, 2024
src/Configuration/test/Placeholder.Test/PlaceholderConfigurationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
TimHess
added
the
ReleaseLine/4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revisits code quality analysis rules. See the individual commit messages for details.
Goals
IDE*rules)IDE*rule configuration with StyleCop/ResharperImplementation
They address specific patterns that are highly unlikely to occur while writing code, so the increased build time by turning them on isn't justifiable.
CA*analyzersIDE*analyzersLinks
Closes #913, closes #916, closes #930.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.