Prefer a store specific payment method if it exists#106
Open
emileswarts wants to merge 1 commit into
Open
Conversation
luukveenis
requested changes
Jun 13, 2017
luukveenis
left a comment
luukveenis
left a comment
Member
There was a problem hiding this comment.
Thanks for submitting this PR!
I'd be happy to merge this in, just 2 minor comments.
| payment | ||
| end | ||
|
|
||
| def payment_method_for(order) |
Member
There was a problem hiding this comment.
We shouldn't need to pass the order to this method since the class is initialized with it. With it removed the method can probably also be renamed to something like hpp_payment_method.
|
|
||
| def payment_method_for(order) | ||
| order.store.payment_methods.where(type: 'Spree::Gateway::AdyenHPP', active: true).last! | ||
| rescue |
Member
There was a problem hiding this comment.
I'm not a big fan of rescuing everything, I would prefer something like:
order.store.payment_methods.active.find_by(type: "Spree::Gateway::AdyenHPP") || Spree::Gateway::AdyenHPP.last
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multi store environment it is desirable to use the store specific payment method.
If one is not defined, default back to the last Adyen payment method it can find.