Make Affirm checkouts non-reusable#2
Merged
Conversation
This commit into core: solidusio/solidus@547d459 Added a check if payment sources are `#reusable?`. The `SolidusAffirm::Checkout` model here is used as the payment source, but doesn't implement that method, causing any code that looks up reusable sources to throw a method missing error. One example where I've seen this error is the /admin/payments/new page.
adammathys
approved these changes
Jul 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit into core:
solidusio/solidus@547d459
Added a check if payment sources are
#reusable?. TheSolidusAffirm::Checkoutmodel here is used as the payment source, butdoesn't implement that method, causing any code that looks up reusable
sources to throw a method missing error.
One example where I've seen this error is the /admin/payments/new page.