Reduce string conversion in CaseInsensitiveDict lookups #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
implement_get_CaseInsensitiveDict
branch
4 times, most recently
from
3095207 to
a7628d3
Compare
get was previously provided by the parent class which had to raise KeyError for missing values. Since try/except is only cheap for the non-exception case the performance was not good when the key was missing similar to python/cpython#106665 but in the HA case we call this even more frequently
bdraco
force-pushed
the
implement_get_CaseInsensitiveDict
branch
from
a7628d3 to
bdcca7b
Compare
bdraco
changed the title
|
Another thing we can do is skip doing a search if another host asked for a search within 50% of the time since the last search If there are multiple HA hosts on the network they are all asking for searches which drives up the traffic a lot |
|
Thanks! Do you want a release with this? |
Sounds good to me. Should mostly be done in the |
|
No rush on a release. I only noticed it because a user had a LOT of sonos devices. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get_lower in a few more places and guard debug logging to avoid lookups when debug logging is not enabeld