Closed
Conversation
Resolve conflict in docker/base/Dockerfile: keep custom ffmpeg-build stage approach (build from source + runtime shared libs) instead of packaged ffmpeg from main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dosubot
bot
added
the
size:M
Contributor
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://54.175.155.236:6037 🔐 Secure HTTPS URL: https://6037.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
ConnorYoh
approved these changes
Apr 1, 2026
jbrunton96
reviewed
Apr 1, 2026
|
|
||
|
|
||
| # Stage 4: Build Python venv | ||
| # Stage 4: Build FFmpeg from source |
Contributor
There was a problem hiding this comment.
Why build from source instead of just depending on the prebuilt package?
Member
Author
There was a problem hiding this comment.
Because prebuilt is 2 versions behind
Whole reason of this PR 😂 is security updates
Contributor
There was a problem hiding this comment.
Wouldn't it be great if GitHub added some sort of description field to PRs
jbrunton96
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)