Multiple issues related to minfication, merging and bundling js

[gewaechshaus]

Hey there,

I did a composer based installation in a Magento 2.1.4 system. However, oob there seems to be a problem (maybe related to combine/merge/minify js) with an undefined object

window.iasConfig is undefined

See everything frontend related here:
https://www.makerdise.com/3d-druck/ersatzteile.html

I just noticed that there are other missing objects related to the window object.

Best
Jan

[gewaechshaus]

It seems like the spinnerSrc: base64 encoded image, which is a very long string, seems to get cutoff without the closing

 ' 

during the merge/minify process.

https://github.com/Strategery-Inc/Magento2-InfiniteScroll/blob/master/view/frontend/templates/js.phtml#L36

I did set an image in the backend configuration to make the condition match before.

[gewaechshaus]

ReferenceError: IASPagingExtension is not defined

[gewaechshaus]

Definitly related to bundling... I am trying to exclude the .js from it, without success atm

 <exclude>
    <item type="file">Strategery_Infinitescroll::js/infinitescroll.js</item>
</exclude>

[gsomoza]

Thanks for reporting this! @damian-pastorini will take a look ASAP. Meanwhile, if you find a fix, please feel free to submit a PR!

[gsomoza]

@damian-pastorini TBH I don't see why we have to use PHP to echo that? It seems like that whole string can go straight into the JS. And there might even be better options than doing that in the first place.

[gewaechshaus]

I enabled the debug flag on www.makedise.com... I tried all possible variations to exclude it from bundling, actually without success.

[gsomoza]

I think the problem is not with bundling, but with how we're trying to import and use some of the IAS extensions (it's currently failing to use the IASPagerExtension).

We should look into how to properly use IAS using RequireJS: we should distribute the original files instead of the minified versions and require them through RequireJS - since Magento 2 will take care of minifying them, etc, using their toolchain.

[gsomoza]

This may even be an opportunity to NOT distribute IAS using this extension, but rather let npm handle that (assuming that IAS is available on npm).

[gewaechshaus]

@gsomoza - if I disable minification, merging and bundling the module works as expected, but you're right.

https://www.npmjs.com/package/jquery-ias

[gewaechshaus]

I just uploaded
https://github.com/webcreate/infinite-ajax-scroll/blob/master/src/jquery-ias.js
to the related folder and changed
https://github.com/Strategery-Inc/Magento2-InfiniteScroll/blob/master/view/frontend/requirejs-config.js#L18
to
jqueryIas: 'Strategery_Infinitescroll/js/jquery-ias'

Did a setup:static-content:deploy ... and flushed/cleaned all caches, but that doesn't seem to affect the IAS...

In fact, the current version is 16kb compared to 18kb of the older minified version that comes with the module.

[gewaechshaus]

Just a note, no solution to fix the issue:
The < exclude > does work in a custom child theme by setting this code in etc/view.xml

 <view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/view.xsd">
   <exclude>
       <item type="file">Strategery_Infinitescroll::js/infinitescroll.js</item>
       <item type="file">Strategery_Infinitescroll::js/jquery-ias.js</item>
   </exclude>