Fix Uncaught TypeError: $(...).catalogAddToCart is not a function issue#28
Merged
gsomoza merged 1 commit intoStrategery-Inc:masterfrom May 8, 2019
Merged
Conversation
Collaborator
Author
|
@gsomoza could you review this PR? |
Contributor
|
The code looks good and makes sense too. Were you able to confirm this against a clean M2 installation with this plugin? If so then we'll merge directly (otherwise we'll have to test that ourselves, which might take a bit). |
Collaborator
Author
|
@gsomoza sure, I just installed module and on category page got this issue (merge of js is disabled, developer mode enabled) |
Contributor
|
Ok but it sound like we'll have to quickly test on a clean Magento install just in case. I'm 99% sure it will work, but we need to do that just to be 100% sure. Thanks a lot for the pull request! We'll try to merge it ASAP. |
gsomoza
added
test-and-merge
Contributor
|
@damian-pastorini could you please assign this to Juan or Vitaly? (or if you find the time you can do it yourlself if you want) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue described in #24