Change PHP 7 constraint to allow 7.4#63
Merged
gsomoza merged 1 commit intoStrategery-Inc:masterfrom Nov 5, 2020
pikulsky:feature/php-constraint-7.4
Merged
Change PHP 7 constraint to allow 7.4#63gsomoza merged 1 commit intoStrategery-Inc:masterfrom pikulsky:feature/php-constraint-7.4
gsomoza merged 1 commit intoStrategery-Inc:masterfrom
pikulsky:feature/php-constraint-7.4
Conversation
Contributor
|
Thanks @pikulsky – out of curiosity were you able to confirm everything works on PHP 7.4 and Magento 2.4? |
Author
Can't confirm: didn't try yet. |
Contributor
|
@damian-pastorini could you please QA this when you get a chance? |
Author
|
@damian-pastorini , @gsomoza , FYI: I've tested it locally, the module works OK in Magent 2.4.0 (PHP 7.4), no issue so far. |
Contributor
|
Thanks @pikulsky, merged and releasing soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magento 2.4 requires PHP ~7.4.0 (see https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements-tech.html#php)