Skip to content

Change PHP 7 constraint to allow 7.4#63

Merged
gsomoza merged 1 commit intoStrategery-Inc:masterfrom
pikulsky:feature/php-constraint-7.4
Nov 5, 2020
Merged

Change PHP 7 constraint to allow 7.4#63
gsomoza merged 1 commit intoStrategery-Inc:masterfrom
pikulsky:feature/php-constraint-7.4

Conversation

@pikulsky
Copy link

@gsomoza
Copy link
Contributor

gsomoza commented Aug 12, 2020

Thanks @pikulsky – out of curiosity were you able to confirm everything works on PHP 7.4 and Magento 2.4?

@gsomoza gsomoza added the test-and-merge For pull requests: test them on clean install, and if they work: merge. label Aug 12, 2020
@pikulsky
Copy link
Author

Thanks @pikulsky – out of curiosity were you able to confirm everything works on PHP 7.4 and Magento 2.4?

Can't confirm: didn't try yet.

@gsomoza
Copy link
Contributor

gsomoza commented Aug 21, 2020

@damian-pastorini could you please QA this when you get a chance?

@pikulsky
Copy link
Author

pikulsky commented Sep 28, 2020

@damian-pastorini , @gsomoza , FYI: I've tested it locally, the module works OK in Magent 2.4.0 (PHP 7.4), no issue so far.

@gsomoza gsomoza merged commit e6cd934 into Strategery-Inc:master Nov 5, 2020
@gsomoza
Copy link
Contributor

gsomoza commented Nov 5, 2020

Thanks @pikulsky, merged and releasing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted test-and-merge For pull requests: test them on clean install, and if they work: merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants