Generic compute plan #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelgnu
reviewed
Dec 2, 2019
inelgnu
reviewed
Dec 2, 2019
tests/test_execution_compute_plan.py
Outdated
|
|
||
| # TODO make sur the creation is rejected | ||
| cp = session.add_compute_plan(cp_spec) | ||
| assert False |
jmorel
force-pushed
the
generic-compute-plan
branch
from
4765e5d to
5ee8305
Compare
samlesu
requested changes
Dec 3, 2019
jmorel
force-pushed
the
generic-compute-plan
branch
from
61e9bf4 to
a0b9acb
Compare
samlesu
requested changes
Dec 3, 2019
samlesu
reviewed
Dec 3, 2019
samlesu
reviewed
Dec 3, 2019
samlesu
reviewed
Dec 3, 2019
jmorel
force-pushed
the
generic-compute-plan
branch
from
fe376b4 to
790462f
Compare
samlesu
reviewed
Dec 4, 2019
samlesu
requested changes
Dec 4, 2019
samlesu
reviewed
Dec 5, 2019
samlesu
reviewed
Dec 5, 2019
inelgnu
approved these changes
Dec 5, 2019
samlesu
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 tests for generic compute plans:
test_aggregate_composite_traintuplesin a compute planThis required to update
factory.pyquite a bit.