Rewrite $alias into Typescript + subcommand structure
#133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Supinic
commented
Jul 15, 2025
Supinic
commented
- also fix some other things related to the command while at it
- maybe even add tests (!)
Open
# Conflicts: # package.json # yarn.lock
# Conflicts: # classes/command.ts # commands/alias/index.js # platforms/twitch.ts
- forces the usage of `import type` wherever necessary; this is very useful for native NodeJS running of TS - mostly for tests this time around, but could be expanded further - also some other minor lint fixes
# Conflicts: # package.json # yarn.lock
# Conflicts: # tsconfig.json
- include JSONified result in expected cmd fail/success - mock getParentAlias - mock User.getAsserted - add missing coverage ignore for assert error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.