Prevent copy tests from failing in Rust 1.90 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue where changed: rust-lang/rust#139956 Comment noting breakage of non-socket converted to UnixStream: 'rust-lang/rust#140005 (comment)' Bumps MSRV from 1.83.0 to 1.87.0 by use of PipeWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, the original issue that required all the CI wrangling.
As a reminder, in Rust 1.90 the behavior of UnixStream is changing to set
MSG_NOSIGNALon writes. This meansUnixStreamis no longer suited for writing to non-socket file descriptors.This fix uses the fairly new PipeWriter, which is designed to do this kind of write, and bumps MSRV from 1.83.0 to 1.87.0.
Happy I did a second run of all of the tests on beta, which caught the second
UnixStreamintroduced in the primary selection changes.