fix: add line break support to Graphics.drawString() #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wizardry Chapter 1 uses line breaks in `game.en.0` but standard MIDP ignores them, causing text overflow. Modified drawString() to handle line breaks. Note: May affect other games using line breaks differently.
Collaborator
|
It's not that standard MIDP ignores line breaks when rendering text through Looks like that for at least earlier jars, handling those is expected. As for the patch itself, looks good, merging! In case of any breakages down the line, this can be improved upon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wizardry Chapter 1 uses line breaks in
game.en.0but standard MIDP ignores them, causing text overflow.Modified drawString() to handle line breaks.
Note: May affect other games using line breaks differently.
#173