Skip to content

Skill role refactor #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

michael-kenzel
Copy link
Contributor

@michael-kenzel michael-kenzel commented May 6, 2025

Yet more untethering: make the bot core independent from skill role stuff.

  • role-manager now only responsible for keeping track of role assignments, offers events other components can hook into to run checks and be notified of role changes
  • remove debounce_map, not necessary anymore since role change events only fire once for each change
  • Introduce SkillRoles component to house skill role logic and tracking
  • Move skill role tracking and pink role handling into new SkillRoles and Pink components
  • simplify skill role logic by using sets instead of arrays
  • Introduce established role to replace skill-role-based checks for screenshots and invite links
    • Wheatley now only offers an is_established_member() method
    • the idea is that the role will be auto-assigned based on server-specific criteria by another server-specific component (will be added in a separate PR)

Copy link

sonarqubecloud bot commented May 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant