Remove local RED4ext Version shim and rely on upstream red-lib compatibility

[dependabot]

The branch already updates client/red4ext/deps/red-lib to a revision that supports current RED4ext header layout. This PR removes the repo-local compatibility shim that became redundant and could mask upstream integration issues.

• Problem context

  • red-lib was bumped to a version that handles RED4ext API version header differences internally.
  • A local shim (client/red4ext/src/RED4ext/Api/Version.hpp) was still present in the PR and no longer needed.

• Change made

  • Deleted the local compatibility header override:
    • /home/runner/work/Cyberverse/Cyberverse/client/red4ext/src/RED4ext/Api/Version.hpp

• Resulting behavior

  • Include resolution now uses dependency-provided RED4ext headers directly, with compatibility handled by red-lib itself.

- client/red4ext/src/RED4ext/Api/Version.hpp

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[MeFisto94]

@dependabot rebase

[MeFisto94]

@copilot the build is failing due to changes around redlib and red4ext.
See the last commit to master for how this was solved in red4ext and fix this branch too

[Copilot]

@copilot the build is failing due to changes around redlib and red4ext.
See the last commit to master for how this was solved in red4ext and fix this branch too

Fixed in fba3be8. I restored the RED4ext compatibility shim at client/red4ext/src/RED4ext/Api/Version.hpp so red-lib can include RED4ext/Api/Version.hpp again with the current SDK layout.

[MeFisto94]

@copilot We have some more, other, breakages. Read the CI Logs and:

  C:\PROGRA~1\MICROS~2\18\ENTERP~1\VC\Tools\MSVC\1451~1.362\bin\Hostx64\x64\cl.exe  /nologo /TP -DABSL_CONSUME_DLL -DCyberverse_Red4Ext_EXPORTS -DNOMINMAX -DPROTOBUF_USE_DLLS -DRED4EXT_STATIC_LIB -D_WINDOWS -ID:\a\Cyberverse\Cyberverse\client\red4ext\src -ID:\a\Cyberverse\Cyberverse\client\red4ext\deps\red4ext.sdk\include -ID:\a\Cyberverse\Cyberverse\client\red4ext\deps\red4ext.sdk\vendor\D3D12MemAlloc -ID:\a\Cyberverse\Cyberverse\client\red4ext\deps\zpp_bits -ID:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include -ID:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\vendor -ID:\a\Cyberverse\Cyberverse\client\red4ext\..\..\shared\protocol -external:ID:\a\Cyberverse\Cyberverse\client\red4ext\build\ninja-vcpkg\vcpkg_installed\x64-windows\include\GameNetworkingSockets -external:ID:\a\Cyberverse\Cyberverse\client\red4ext\build\ninja-vcpkg\vcpkg_installed\x64-windows\include -external:W0 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /MDd /Zi /Ob0 /Od /RTC1 -std:c++20 /showIncludes /Fosrc\CMakeFiles\Cyberverse.Red4Ext
  Error: D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(670): error C3609: 'Red::ClassDescriptorDefaultImpl<TClass>::IsEqual': a 'final' function must be virtual
          with
          [
              TClass=NetworkGameSystem
          ]
  D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(670): note: the template instantiation context (the oldest one first) is
  D:\a\Cyberverse\Cyberverse\client\red4ext\src\NetworkGameSystem.h(82): note: see reference to class template instantiation 'Red::ClassDefinition<NetworkGameSystem>' being compiled
  D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(1044): note: while compiling class template member function 'void Red::ClassDefinition<NetworkGameSystem>::DescribeType(void)'
  D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(1099): note: see the first reference to 'Red::ClassDefinition<NetworkGameSystem>::DescribeType' in 'void __cdecl `dynamic initializer for 'public: static Red::TypeInfoRegistrar Red::ClassDefinition<NetworkGameSystem>::s_registrar''(void)'
  D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(1049): note: see reference to class template instantiation 'Red::ClassDescriptorDefaultImpl<TClass>' being compiled
          with
          [
              TClass=NetworkGameSystem
          ]
  Error: D:\a\Cyberverse\Cyberverse\client\red4ext\deps\red-lib\include\Red\TypeInfo/Definition.hpp(692): error C3609: 'Red::ClassDescriptorDefaultImpl<TClass>::Assign': a 'final' function must be virtual
          with
          [
              TClass=NetworkGameSystem
          ]

[Copilot]

@copilot We have some more, other, breakages. Read the CI Logs and:

...

Addressed in commits f087363 and 098b8ad.

I fixed the reported breakages by:

• adding a local red-lib typeinfo compatibility overlay to resolve the ClassDescriptorDefaultImpl::IsEqual/Assign signature mismatch with current RED4ext headers,
• fixing ParseHostFromCommandLine / ParsePortFromCommandLine to use constexpr needles (resolving the C2131 constant-evaluation errors).

A new CI run was triggered for the latest commit (098b8ad).

[MeFisto94]

@copilot Keep the constexpr fixes, but I don't agree to changing redlib code, instead, we should improve our implementation

[Copilot]

@copilot Keep the constexpr fixes, but I don't agree to changing redlib code, instead, we should improve our implementation

Addressed in e5e75f0.

I kept the constexpr command-line fixes, removed the local red-lib overlay files, and switched to a project-side compatibility approach by specializing class descriptors only for our types (NetworkGameSystem and PlayerActionTracker) instead of modifying red-lib code.

[dependabot]

A newer version of client/red4ext/deps/red-lib exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.