Future Works

1. It would be better to localize some of the strings like the Gift
2. Testing is not quite there. Did not have time to test the repositories
3. The Methods for the mapping or Repository objects to Domain objects should be removed from the Tracking service. These should really be in their own mapping class
4. The validation annotation used on the RequestDTO does not seem to validate email ok. Coding error or a missunderstanding of how this validator works. Would like to investigate this one more
5. Would be nice to validate the customerId as well. I would do this with some regex if I had specification for it.
6. EF made the DB part of the work simpler but I am not happy with the sorting code being in the repository. Technically this is business logic. I would like to expplore passing in an expression to the Repo and letting the code the business layer decide on the sorting logic
7. There isn't enough resiliance on the calls being made to the Customer details API. With more time, I would add some retry logic
8. This data is highly cachable since the expected date is unlikely to be changing frequently. With time, I would cache both the calls to the DB and the API
9. Logging is a little sparse. With more time I would make this log more details. My only concern is logging emails might break GDPR. Would be one to check with the DPO
10. I have not made considerations for security. Someone could send int a large text for the customerId and rapidly do this to DDoS the service.
11. Hardnening - Enforcement of Https. Although depending on the hosting environment this may not need to be done in code
12. Hardnening - Removal of any headers that might give away the technology used
13. This service is actually best hosted in an azure function. I would write and deploy this there.