Skip to content

feat(workflows): Update create-pr.md workflow instructions #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xunma wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(workflows): Update create-pr.md workflow instructions #348

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74074ed
docs: Update create-pr.md workflow instructions
xunma Sep 17, 2025
05f86db
feat(workflows): follow up with 3 options if no issue is provided
xunma Sep 17, 2025
cfb62c4
feat(workflows): improve UX for find issue option
xunma Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pochi/workflows/create-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Please help create a PR for the current staging changes, following these guidelines:
- If an issue number is not provided, use askFollowupQuestion to ask for it. If user provides a valid issue number, link to the issue with `Resolves <ISSUE_NUMBER>` at the beginning of the PR description.
Copy link
Member

@wsxiaoys wsxiaoys Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give an option of askFollowUpQuestion that help user find the issue. (have issue / no issue / find issue for me)

Copy link
Collaborator Author

@xunma xunma Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wsxiaoys nice suggestion. it works well 👉 https://app.getpochi.com/tasks/jUcSdiIW

only minor thing is, when user select find issue for me, the output by default is collapsed — user needs to manually open it to see the full issue list. I think it wouldn't be a big issue, as the user of this workflow should know they can open the list..

Copy link
Member

@wsxiaoys wsxiaoys Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can optimize prompt to make it generates better output and confirm it with user.

Copy link
Collaborator Author

@xunma xunma Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wsxiaoys okie! I specified the output format(not sure if I am being too specific here...)

When choosing find issue for me:

- If there are no staging changes but there are uncommitted changes, please stage them first.
- Create a branch name based on the current git diff status.
- Write a meaningful commit message/PR title.
- Write a meaningful commit message/PR title/PR description.
- Use the gh CLI to create a PR.
- When running the push operation, it might be aborted due to a husky pre-push hook. For formatting issues, amend the files and try again. For other issues, try to resolve them as much as possible.
- The base branch for the PR should always be `origin/main`.
Expand Down