Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { Separator } from "@/components/ui/separator";
import { Switch } from "@/components/ui/switch";
import { cn } from "@/lib/utils";
import {
Blocks,
CheckIcon,
Eye,
FileEdit,
Expand All @@ -22,8 +21,10 @@ import {
import { useEffect, useState } from "react";
import { useTranslation } from "react-i18next";
import { useAutoApprove } from "../hooks/use-auto-approve";
import { useMcpAutoApproveDefaults } from "../hooks/use-mcp-auto-approve-defaults";
import { useSubtaskOffhand } from "../hooks/use-subtask-offhand";
import { type AutoApprove, GlobalStateStorage } from "../store";
import { McpAutoApproveSection } from "./mcp-auto-approve-section";

interface CoreActionSetting {
id: keyof Omit<AutoApprove, "default">;
Expand Down Expand Up @@ -68,12 +69,6 @@ export function AutoApproveMenu({ isSubTask }: { isSubTask: boolean }) {
label: t("settings.autoApprove.executeCommands"),
iconClass: Terminal,
},
{
id: "mcp",
summary: t("settings.autoApprove.mcp"),
label: t("settings.autoApprove.useMcpServers"),
iconClass: Blocks,
},
];

const handleCoreActionToggle = (
Expand Down Expand Up @@ -125,6 +120,7 @@ export function AutoApproveMenu({ isSubTask }: { isSubTask: boolean }) {
...coreActionSettings
.filter((setting) => getCoreActionCheckedState(setting.id))
.map((setting) => setting.summary),
...(autoApproveSettings.mcp ? [t("settings.autoApprove.mcp")] : []),
...(autoApproveSettings.retry ? [t("settings.autoApprove.retry")] : []),
];

Expand Down Expand Up @@ -165,6 +161,13 @@ export function AutoApproveMenu({ isSubTask }: { isSubTask: boolean }) {
setIsDirty(hasChanges);
}, [autoApproveSettings, subtaskOffhand, initialSettings, isSubTask]);

// Migration: Automatically enable all MCP servers when mcp is true but mcpServers is undefined (not configured yet)
useMcpAutoApproveDefaults({
autoApproveSettings,
updateAutoApproveSettings,
handlePersistSettings,
});

return (
<Popover onOpenChange={onOpenChange}>
<PopoverTrigger asChild>
Expand Down Expand Up @@ -237,6 +240,12 @@ export function AutoApproveMenu({ isSubTask }: { isSubTask: boolean }) {
))}
</div>
<Separator className="my-3" />
{/* MCP Section */}
<McpAutoApproveSection
autoApproveSettings={autoApproveSettings}
updateAutoApproveSettings={updateAutoApproveSettings}
/>
<Separator className="my-3" />
{/* Max Attempts Section */}
<div className="flex h-7 items-center pl-1">
<Checkbox
Expand Down
Loading