Skip to content

Fix type of utils in collection options#866

Merged
kevin-dp merged 6 commits intomainfrom
kevin/type-option-utils
Dec 1, 2025
Merged

Fix type of utils in collection options#866
kevin-dp merged 6 commits intomainfrom
kevin/type-option-utils

Conversation

@kevin-dp
Copy link
Copy Markdown
Contributor

@kevin-dp kevin-dp commented Nov 20, 2025

Trying to fix #792

const todosCollection = createCollection(
  electricCollectionOptions({
    id: 'todos',
    getKey: (item) => item.id,
    shapeOptions: {
      url: '/api/todos',
      params: { table: 'todos' },
    },
    onInsert: async ({ collection }) => {
      // ❌ This is typed as UtilsRecord instead of ElectricCollectionUtils<T>
      collection.utils;
    },
  }),
);

// ✅ This is typed as ElectricCollectionUtils<T>
todosCollection.utils;

I believe that we also broke todosCollection.utils because my VS Code IntelliSense indicates that it is also UtilsRecord.

The problem is an intersection type once again!

export function electricCollectionOptions<T extends StandardSchemaV1>(
  config: ElectricCollectionConfig<InferSchemaOutput<T>, T> & {
    schema: T
  }
): CollectionConfig<InferSchemaOutput<T>, string | number, T> & {
  id?: string
  utils: ElectricCollectionUtils
  schema: T
}

The issue is that utils appears on both sides of the intersection type. On the left inside CollectionConfig it is typed as UtilsRecord because we don't actually pass it through:

CollectionConfig<InferSchemaOutput<T>, string | number, T>

It's a hard one to solve though because of the optionality of utils in the base config but it being non-optional in the Electric collection options. Also for some reason my VS Code's IntelliSense gets confused all the time on this type which makes it hard to fix.

EDIT: it seems that the only way to solve this optionality issue is to introduce some more overloads.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: ffadc15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Nov 20, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@866

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@866

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@866

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@866

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@866

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@866

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@866

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@866

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@866

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@866

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@866

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@866

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@866

commit: ffadc15

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2025

Size Change: 0 B

Total Size: 87.1 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 1.38 kB
./packages/db/dist/esm/collection/changes.js 977 B
./packages/db/dist/esm/collection/events.js 388 B
./packages/db/dist/esm/collection/index.js 3.24 kB
./packages/db/dist/esm/collection/indexes.js 1.1 kB
./packages/db/dist/esm/collection/lifecycle.js 1.67 kB
./packages/db/dist/esm/collection/mutations.js 2.31 kB
./packages/db/dist/esm/collection/state.js 3.43 kB
./packages/db/dist/esm/collection/subscription.js 2.55 kB
./packages/db/dist/esm/collection/sync.js 2.37 kB
./packages/db/dist/esm/deferred.js 207 B
./packages/db/dist/esm/errors.js 4.19 kB
./packages/db/dist/esm/event-emitter.js 748 B
./packages/db/dist/esm/index.js 2.64 kB
./packages/db/dist/esm/indexes/auto-index.js 742 B
./packages/db/dist/esm/indexes/base-index.js 766 B
./packages/db/dist/esm/indexes/btree-index.js 1.87 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.1 kB
./packages/db/dist/esm/indexes/reverse-index.js 513 B
./packages/db/dist/esm/local-only.js 837 B
./packages/db/dist/esm/local-storage.js 2.1 kB
./packages/db/dist/esm/optimistic-action.js 359 B
./packages/db/dist/esm/paced-mutations.js 496 B
./packages/db/dist/esm/proxy.js 3.69 kB
./packages/db/dist/esm/query/builder/functions.js 733 B
./packages/db/dist/esm/query/builder/index.js 3.96 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 917 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.35 kB
./packages/db/dist/esm/query/compiler/expressions.js 430 B
./packages/db/dist/esm/query/compiler/group-by.js 1.8 kB
./packages/db/dist/esm/query/compiler/index.js 1.96 kB
./packages/db/dist/esm/query/compiler/joins.js 2 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.25 kB
./packages/db/dist/esm/query/compiler/select.js 1.07 kB
./packages/db/dist/esm/query/expression-helpers.js 1.43 kB
./packages/db/dist/esm/query/ir.js 673 B
./packages/db/dist/esm/query/live-query-collection.js 360 B
./packages/db/dist/esm/query/live/collection-config-builder.js 5.33 kB
./packages/db/dist/esm/query/live/collection-registry.js 264 B
./packages/db/dist/esm/query/live/collection-subscriber.js 1.74 kB
./packages/db/dist/esm/query/live/internal.js 130 B
./packages/db/dist/esm/query/optimizer.js 2.56 kB
./packages/db/dist/esm/query/predicate-utils.js 2.91 kB
./packages/db/dist/esm/query/subset-dedupe.js 921 B
./packages/db/dist/esm/scheduler.js 1.3 kB
./packages/db/dist/esm/SortedMap.js 1.18 kB
./packages/db/dist/esm/strategies/debounceStrategy.js 247 B
./packages/db/dist/esm/strategies/queueStrategy.js 428 B
./packages/db/dist/esm/strategies/throttleStrategy.js 246 B
./packages/db/dist/esm/transactions.js 2.9 kB
./packages/db/dist/esm/utils.js 881 B
./packages/db/dist/esm/utils/browser-polyfills.js 304 B
./packages/db/dist/esm/utils/btree.js 5.61 kB
./packages/db/dist/esm/utils/comparison.js 852 B
./packages/db/dist/esm/utils/index-optimization.js 1.51 kB
./packages/db/dist/esm/utils/type-guards.js 157 B

compressed-size-action::db-package-size

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2025

Size Change: 0 B

Total Size: 3.34 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 225 B
./packages/react-db/dist/esm/useLiveInfiniteQuery.js 1.17 kB
./packages/react-db/dist/esm/useLiveQuery.js 1.11 kB
./packages/react-db/dist/esm/useLiveSuspenseQuery.js 431 B
./packages/react-db/dist/esm/usePacedMutations.js 401 B

compressed-size-action::react-db-package-size

@kevin-dp kevin-dp force-pushed the kevin/type-option-utils branch from f95e52e to 5ceb20b Compare November 24, 2025 08:22
@kevin-dp kevin-dp requested a review from samwillis November 24, 2025 09:08
Copy link
Copy Markdown
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kevin-dp kevin-dp force-pushed the kevin/type-option-utils branch from 99c2bed to 1c8e08b Compare December 1, 2025 08:32
@kevin-dp kevin-dp merged commit 8c26dca into main Dec 1, 2025
7 checks passed
@kevin-dp kevin-dp deleted the kevin/type-option-utils branch December 1, 2025 08:42
kevin-dp added a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Electric collection utils are not typed in mutation functions

2 participants