-
-
Notifications
You must be signed in to change notification settings - Fork 602
fix(core): field unmount #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TkDodo
wants to merge
11
commits into
TanStack:main
Choose a base branch
from
TkDodo:feature/fix/field-unmount
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+536
−11
Open
fix(core): field unmount #2068
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2afa535
fix: make field unmount
TkDodo 29038e6
more tests
TkDodo eb780f7
ref: prefer object.entries
TkDodo 7dadaa7
jsdoc
TkDodo 8e9635c
Fix field unmount issue in core
TkDodo 9f7489e
ci: apply automated fixes and generate docs
autofix-ci[bot] b411f59
fix: update fieldInfo type to be partial and handle unmounted fields
TkDodo 4eff6fa
fix: cleanupFieldsOnUnmount flag
TkDodo 10abde0
fix: eslint
TkDodo 8b41487
fix: coderabbit findings
TkDodo 09307f6
fix: ensure async validation cancellation on field unmount
TkDodo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@tanstack/form-core': patch | ||
| '@tanstack/react-form': patch | ||
| --- | ||
|
|
||
| fix(core): field unmount |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.