-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: suspense for useQueries #4498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e133b0d:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4498 +/- ##
==========================================
- Coverage 96.36% 92.40% -3.96%
==========================================
Files 45 89 +44
Lines 2281 3675 +1394
Branches 640 959 +319
==========================================
+ Hits 2198 3396 +1198
- Misses 80 263 +183
- Partials 3 16 +13 ☔ View full report in Codecov by Sentry. |
wow, so now useQueries support suspense? cool! |
@dante01yoon yep, shipped that yesterday with 4.15.0. Please try it out and give feedback. I've written two tests and they work and that's about it 😅 |
Oh and btw, it fires all requests in parallel, and you can even combine suspense |
Seems work as intended! I think it might be better add some more test codes. May be I can do help with that |
Yes thanks. I'll happily accept PRs that add more tests 🙌 |
I just added two tests based on your previous tests; whether it works on global configuration, check component only amounts after all queries fetched. |
fixes #1523