Skip to content

ci: Remove codesandbox #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

ci: Remove codesandbox #6814

merged 1 commit into from
Feb 3, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 3, 2024

The GitHub workflow now builds all examples, superseding codesandbox.

Codesandbox has very frustrating restrictions, like not having corepack/pnpm, and how Node "18" always means 18.12.1. This means it refuses to build recent Next.js versions, which require 18.17.0+.

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Feb 3, 2024 4:56am

Copy link

nx-cloud bot commented Feb 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 131b25b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2aeb0bf) 41.78% compared to head (131b25b) 41.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6814   +/-   ##
=======================================
  Coverage   41.78%   41.78%           
=======================================
  Files         178      178           
  Lines        7017     7017           
  Branches     1421     1421           
=======================================
  Hits         2932     2932           
  Misses       3722     3722           
  Partials      363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 8450d9a into main Feb 3, 2024
@lachlancollins lachlancollins deleted the remove-csb branch February 3, 2024 05:01
@TkDodo
Copy link
Collaborator

TkDodo commented Feb 3, 2024

We were using codesandbox to create a preview build on the PR. What's the replacement for this please?

@lachlancollins
Copy link
Member Author

We were using codesandbox to create a preview build on the PR. What's the replacement for this please?

All packages and examples were changed to build on GitHub workflow by #6813 , so from what I can tell, CSB wasn't adding anything to the workflow anymore. Is there something we still need CSB for?

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 3, 2024

The codesandbox bot was posting a link where the examples are built with the new code. You could play around with that. You could also use the csb preview builds in your own app to manually verify if the change works as expected.

Also, if a linked issue had a csb reproduction, csb would build that as well with the PR code so that you can verify that the failing reproduction now works. I think that was quite valuable

@lachlancollins
Copy link
Member Author

The codesandbox bot was posting a link where the examples are built with the new code. You could play around with that. You could also use the csb preview builds in your own app to manually verify if the change works as expected.

Also, if a linked issue had a csb reproduction, csb would build that as well with the PR code so that you can verify that the failing reproduction now works. I think that was quite valuable

Ahh I see - that's quite useful. Would be nice if codesandbox worked a bit better but oh well!

lachlancollins added a commit that referenced this pull request Feb 3, 2024
lachlancollins added a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants