-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: correct variable assignment for risk manager #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ger. fundamental_report was referencing to news_report state
Summary of ChangesHello @Laxmi884, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a variable assignment bug in the risk_manager where fundamentals_report was being assigned the wrong state value. However, a high-severity Prompt Injection vulnerability has been identified where the agent constructs an LLM prompt by directly embedding unsanitized data, potentially allowing an attacker to manipulate trading decisions. Additionally, my review suggests improving the robustness of state access to prevent potential runtime errors.
| market_research_report = state["market_report"] | ||
| news_report = state["news_report"] | ||
| fundamentals_report = state["news_report"] | ||
| fundamentals_report = state["fundamentals_report"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A high-severity Prompt Injection vulnerability exists here: the risk_manager_node function constructs an LLM prompt by directly embedding unsanitized content from the state object, including reports like market_research_report and fundamentals_report. This allows an attacker to inject malicious instructions and manipulate trading decisions. While the change on line 14 fixes a bug, it is part of this vulnerable data flow. Additionally, the current state access using [] can lead to KeyError if keys are missing; consider using .get() for more robust state access.
Hi,
I’ve made a change to address an issue where the risk_manager agent was incorrectly assigning the news_report_state instead of the fundamentals_report_state to fundamentals_report during its creation.
File Changed: risk_manager.py (1 line changed)