Skip to content

Conversation

@Tinyblargon
Copy link
Collaborator

Add LXC pool updating.

Propagate the EncodedVersion instead of the Version.

@Tinyblargon Tinyblargon requested a review from Copilot September 16, 2025 21:23
@Tinyblargon Tinyblargon self-assigned this Sep 16, 2025
@Tinyblargon Tinyblargon added type/enhancement An improvement of existing functionality modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files test/done This PR has been tested and the result was succesfull labels Sep 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to propagate EncodedVersion instead of Version throughout the API mapping and pool management functions. The change improves consistency by avoiding repeated encoding operations and adds LXC pool updating functionality.

  • Updated function signatures to accept EncodedVersion parameters directly
  • Modified version comparisons to use encoded versions consistently
  • Added LXC pool updating support with proper version handling

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
proxmox/config__qemu_test.go Updated test calls to encode version before passing to mapToAPI
proxmox/config__qemu__cpu.go Changed CPU mapping functions to accept EncodedVersion
proxmox/config__qemu__cloudinit.go Updated CloudInit mapping to use EncodedVersion
proxmox/config__qemu.go Modified QEMU config mapping and pool operations to use encoded versions
proxmox/config__pool.go Updated pool management functions to accept EncodedVersion
proxmox/config__lxc__new.go Added LXC pool updating functionality and improved error handling
proxmox/config__guest.go Updated guest pool management to use EncodedVersion

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

requiresOffStateForMountActions = markedMounts.offState
}

var err error
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable err is being redeclared. Since err is already used in the function signature's return parameters, this redeclaration shadows the return variable and could lead to confusion. Remove this declaration and use the existing return parameter directly.

Copilot uses AI. Check for mistakes.
@Tinyblargon Tinyblargon merged commit cfda8ee into Telmate:master Sep 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files test/done This PR has been tested and the result was succesfull type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant