Feat: HaResource delete

[Tinyblargon]

Adds functionality to delete a HA Resource.

Removes unused rawDigest from the HA rules.

Related to Telmate/terraform-provider-proxmox#1394

[Copilot]

Pull Request Overview

This PR adds functionality to delete High Availability (HA) resources and removes unused rawDigest fields from HA rule structures. The implementation includes proper error handling for cases where the HA resource doesn't exist.

• Adds DeleteHaResource method for GuestID with comprehensive error handling
• Removes unused rawDigest field from HaNodeAffinityRule and HaResourceAffinityRule structs
• Updates corresponding test cases to reflect the removal of rawDigest

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
proxmox/error.go	Adds new error types for HA resource deletion scenarios
proxmox/config__guest.go	Implements the main HA resource deletion functionality
proxmox/client__new.go	Adds interface method for HA resource deletion
proxmox/client__new__mock.go	Implements mock for HA resource deletion
proxmox/client__api.go	Adds low-level API interface and implementation
proxmox/client__api__mock.go	Adds mock implementation for API interface
proxmox/config__ha__rules.go	Removes unused rawDigest fields from HA rule structs
proxmox/config__ha__rules_test.go	Updates tests to remove rawDigest references

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Using string prefix matching on error messages is fragile and could break if the API error format changes. Consider checking for specific HTTP status codes or using structured error types instead.

Suggested change

	if strings.HasPrefix(err.Error(), "500 cannot delete service") {
	// Try to check for HTTP status code 500 and error message "cannot delete service"
	type httpError interface {
	StatusCode() int
	Error() string
	}
	if herr, ok := err.(httpError); ok {
	if herr.StatusCode() == 500 && strings.Contains(herr.Error(), "cannot delete service") {
	return Error.haResourceDoesNotExist(id)
	}
	} else if strings.HasPrefix(err.Error(), "500 cannot delete service") {
	// Fallback to string matching if error type does not expose status code