Improve logic which reconciles the power state of LXC containers #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the power state and whether it needs to be changed to match the "start" parameter after both cloning and creating an LXC container. I had run into an issue where LXC's would not start after being cloned from another VM. I checked the code and it seemed to be prone to issues, so I've broken that logic out into a function `reconcilePowerState` which is now run when we finish creating or cloning an LXC.
Tinyblargon
added
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the power state and whether it needs to be changed to match the "start" parameter after both cloning and creating an LXC container.
I had run into an issue where LXC's would not start after being cloned from another VM. I checked the code and it seemed to be prone to issues, so I've broken that logic out into a function
reconcilePowerStatewhich is now run when we finish creating or cloning an LXC.From my testing this works much more reliably than before. I'm not sure if there was a reason behind only checking and reconciling the power state if the "start" parameter had changed. If I am understanding correctly, the more "idempotent" thing to do would be to check regardless of the input and change the power state if it needs to be changed. Let me know if I am making any wrong assumptions here.
This is a somewhat quick and dirty proof of concept so definitely let me know if it should be tidied up in any way.
Thanks!