ohos: Improve the skeleton code of ovCompose access to OHOS unified rendering (Render Service) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywenjing
reviewed
Oct 9, 2025
...ion/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: wuxujie <[email protected]>
feat:add picture recorder for render node
|
sebuntin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
2 times, most recently
from
06f7176 to
bd77e49
Compare
…native paint synchronization
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
bd77e49 to
c4be0c4
Compare
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
6eb53db to
fc27bab
Compare
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
5608dc4 to
f2b2658
Compare
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
6690afd to
ff6eb1c
Compare
sebuntin
changed the title
cx478815108
reviewed
Oct 20, 2025
|
|
||
| void OHRenderNodeDrawClipRect(float left, float top, float right, float bottom, const RenderNodeSaveState *saveState, | ||
| BaseRenderNode *renderNodeForDrawing) { | ||
| ArkUI_RectShapeOption *shape = OH_ArkUI_RenderNodeUtils_CreateRectShapeOption(); |
Collaborator
There was a problem hiding this comment.
clip 频率非常高，这个 shape 有办法全局复用吗？或者能否先判断当前的 renderNode 上是否已经存在了 shape ？
Author
There was a problem hiding this comment.
可以考虑将这个shape提取到renderNode中，跟随renderNode的生命周期，只要renderNode不被销毁，shape也可以被这个renderNode一直复用
| return this; | ||
| } | ||
|
|
||
| BaseRenderNode* setTransform(float* matrix) { |
Collaborator
There was a problem hiding this comment.
下面已经有了 BaseRenderNode* setTransform(const float* matrix)，应该可以删除这个了 BaseRenderNode* setTransform(float* matrix)
|
|
||
| // 释放绘制资源 | ||
| OH_Drawing_CanvasDetachPen(canvas); | ||
| OH_Drawing_PathClose(path); |
Collaborator
There was a problem hiding this comment.
看上去少了 OH_Drawing_PathDetory(path) 的调用
|
|
||
| // 释放绘制资源 | ||
| OH_Drawing_CanvasDetachPen(canvas); | ||
| OH_Drawing_PathClose(path); |
Collaborator
There was a problem hiding this comment.
OH_Drawing_PathClose 这个会释放 path 吗？看上去和 OH_Drawing_PathDestory 语义不一样
Author
There was a problem hiding this comment.
这里应该是写错了，应该调用OH_Drawing_PathDestroy方法
| auto *data = static_cast<RectGradientRenderNode *>(userData); | ||
| auto *canvas1 = OH_ArkUI_DrawContext_GetCanvas(context); | ||
| OH_Drawing_Canvas *canvas = reinterpret_cast<OH_Drawing_Canvas *>(canvas1); | ||
| OH_Drawing_ShaderEffect *shaderEffect = CreateShaderEffect(data->shader); |
Collaborator
There was a problem hiding this comment.
这里一定要创建 shaderEffect 吗？
...rc/ohosArm64Main/kotlin/androidx/compose/ui/platform/nativefoundation/AdaptiveCanvas.ohos.kt
Show resolved
Hide resolved
...rc/ohosArm64Main/kotlin/androidx/compose/ui/platform/nativefoundation/AdaptiveCanvas.ohos.kt
Outdated
Show resolved
Hide resolved
| import androidx.compose.ui.graphics.StrokeJoin | ||
| import platform.arkui.OH_Drawing_BlendMode | ||
|
|
||
| internal fun BlendMode.asNativeBlendMode(): OH_Drawing_BlendMode { |
| class OHComposeNativePaint(val handle: OHComposeNativePaint_Handle?) { | ||
| fun sync(paint: Paint) { | ||
| // 实现与 OHComposeNativePaint 的同步逻辑 | ||
| LogPrintUtil.verbose("OHComposeNativePaint::sync, compose paint: (${paint.toReadableString()})") |
Collaborator
There was a problem hiding this comment.
这里要小心，日志创建的字符串，是 100% 创建的
…vCompose text field on the ohos platform
ohos: Fix OverScroll animation issues by correctly parsing VSync sign…
…ust compiler arguments accordingly
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
4 times, most recently
from
176137b to
1d59d24
Compare
…tive canvas proxy resource management
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
1d59d24 to
3a977da
Compare
Oh compose ywenjing
Signed-off-by: wuxujie <[email protected]>
feat:wrapper OH_HiTrace
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
f47f615 to
c03c114
Compare
added 3 commits
October 30, 2025 12:29
sebuntin
force-pushed
the
ohos-compose-1.6.1-20250919
branch
from
c03c114 to
1b2af1e
Compare
Signed-off-by: wuxujie <[email protected]>
feat:implement drawingItem diff
- Add LayerSourceType enum (LAZY_LIST_ITEM, REGULAR) - Extend OwnedLayer interface with getSourceType() method - Update Owner.createLayer() API with sourceType parameter (default=REGULAR) - Update OwnedLayerFactory.createLayer() with sourceType parameter - Implement sourceType in ArkUIRenderNodeLayer with isLazyListItem() helper - Update Placeable.placeWithLayer() and placeRelativeWithLayer() APIs - Update NodeCoordinator and RootNodeOwner to propagate sourceType - LazyListMeasuredItem now passes LAZY_LIST_ITEM when placing items This enables OHOS platform to identify LazyList item layers. fix: 解决LazyColumn组件的滑动问题
…nvas feat: Add support for drawing oval, arc, and path shapes in canvas
… text to SkBitmap
…es, and paths in the canvas
…nd improve border style handling
…and enhance color filter support
…anced gradient rendering capabilities
…ng and reduce memory overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ohos: Add skeleton code for OHOS text measurement and rendering to prevent text rendering process from crashing