Skip to content

Don't silently ignore errors in VkCompute::submit_and_wait#4828

Merged
nihui merged 1 commit intoTencent:masterfrom
Upliner:error-handling
Jul 11, 2023
Merged

Don't silently ignore errors in VkCompute::submit_and_wait#4828
nihui merged 1 commit intoTencent:masterfrom
Upliner:error-handling

Conversation

@Upliner
Copy link
Contributor

@Upliner Upliner commented Jun 29, 2023

Opening this pull request instead of old one with changes requested by reviewer
#4769

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #4828 (b8c3051) into master (903ec7c) will decrease coverage by 4.84%.
The diff coverage is 70.58%.

@@             Coverage Diff             @@
##           master    #4828       +/-   ##
===========================================
- Coverage   94.59%   89.75%    -4.84%     
===========================================
  Files         687      309      -378     
  Lines      207674    84270   -123404     
===========================================
- Hits       196440    75637   -120803     
+ Misses      11234     8633     -2601     
Impacted Files Coverage Δ
src/net.cpp 68.46% <69.23%> (-0.15%) ⬇️
src/gpu.cpp 80.82% <75.00%> (-1.76%) ⬇️

... and 556 files with indirect coverage changes

@nihui nihui merged commit e8645e9 into Tencent:master Jul 11, 2023
@nihui
Copy link
Member

nihui commented Jul 11, 2023

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants